polygene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Merlin <p...@nosphere.org>
Subject Re: Drop Prototype in ValueBuilder in 3.0??
Date Wed, 10 Jun 2015 10:23:13 GMT
Niclas Hedhman a écrit :
> Follow up on this;
>
> I have now removed the Serialization code in the ValueBuilder prototype
> handling, and doing a shallow clone instead.
>
> IMPORTANT: This means that all properties of a ValueComposite MUST BE
> IMMUTABLE.
Seems more than legit.

> In reality, this has always been implied, for instance Collections classes
> in Properties are wrapped in Collections.unmodifiableXyz() calls and
> Property can have ValueComposites, but regular objects are high
> discouraged, although might still be supported. In 3.0, I want to remove
> the possibility to put POJO into Property<?> of ValueComposites and narrow
> down the exact types to support (which will all can be ensured to be
> Immutable).
>
> This works for me, and I have merged these and a bunch of other changes
> into 'develop' branch, for every to take a look.
Made a quick review and all changes looks good to me.

Cheers

/Paul


Mime
View raw message