polygene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nic...@apache.org
Subject zest-java git commit: Wrong sign for detecting something went wrong in the removal of test directories
Date Sat, 16 Apr 2016 05:44:00 GMT
Repository: zest-java
Updated Branches:
  refs/heads/develop 0accd2cf6 -> 36b29175f


Wrong sign for detecting something went wrong in the removal of test directories


Project: http://git-wip-us.apache.org/repos/asf/zest-java/repo
Commit: http://git-wip-us.apache.org/repos/asf/zest-java/commit/36b29175
Tree: http://git-wip-us.apache.org/repos/asf/zest-java/tree/36b29175
Diff: http://git-wip-us.apache.org/repos/asf/zest-java/diff/36b29175

Branch: refs/heads/develop
Commit: 36b29175f53804c627751176cab694352be1825b
Parents: 0accd2c
Author: Niclas Hedhman <niclas@hedhman.org>
Authored: Sat Apr 16 13:43:27 2016 +0800
Committer: Niclas Hedhman <niclas@hedhman.org>
Committed: Sat Apr 16 13:43:27 2016 +0800

----------------------------------------------------------------------
 .../java/org/apache/zest/tools/shell/create/CreateProjectTest.java | 2 +-
 .../zest/tools/shell/create/project/DefaultProjectCreatorTest.java | 2 +-
 .../zest/tools/shell/create/project/NullProjectCreatorTest.java    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zest-java/blob/36b29175/tools/shell/src/test/java/org/apache/zest/tools/shell/create/CreateProjectTest.java
----------------------------------------------------------------------
diff --git a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/CreateProjectTest.java
b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/CreateProjectTest.java
index 58b2a83..0bc193a 100644
--- a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/CreateProjectTest.java
+++ b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/CreateProjectTest.java
@@ -60,7 +60,7 @@ public class CreateProjectTest
 
         assertThat( dest.exists(), equalTo( true ) );
         assertThat( new File(dest, "src/main/java/org/apache/zest/package.html").exists(),
equalTo( true ) );
-        if( FileUtils.removeDir( dest ) )
+        if( ! FileUtils.removeDir( dest ) )
         {
             System.err.println( "Unable to remove file. Why???" );
         }

http://git-wip-us.apache.org/repos/asf/zest-java/blob/36b29175/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/DefaultProjectCreatorTest.java
----------------------------------------------------------------------
diff --git a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/DefaultProjectCreatorTest.java
b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/DefaultProjectCreatorTest.java
index 387fc5f..b269485 100644
--- a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/DefaultProjectCreatorTest.java
+++ b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/DefaultProjectCreatorTest.java
@@ -99,7 +99,7 @@ public class DefaultProjectCreatorTest
         assertThat( new File( projectDir, "gradlew.bat" ).exists(), equalTo( true ) );
         assertThat( new File( projectDir, "build.gradle" ).exists(), equalTo( true ) );
         assertThat( new File( projectDir, "settings.gradle" ).exists(), equalTo( true ) );
-        if( FileUtils.removeDir( projectDir ) )
+        if( !FileUtils.removeDir( projectDir ) )
         {
             System.err.println( "Unable to remove file. Why???" );
         }

http://git-wip-us.apache.org/repos/asf/zest-java/blob/36b29175/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/NullProjectCreatorTest.java
----------------------------------------------------------------------
diff --git a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/NullProjectCreatorTest.java
b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/NullProjectCreatorTest.java
index 45f66fb..e0a470a 100644
--- a/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/NullProjectCreatorTest.java
+++ b/tools/shell/src/test/java/org/apache/zest/tools/shell/create/project/NullProjectCreatorTest.java
@@ -57,7 +57,7 @@ public class NullProjectCreatorTest
         assertThat( new File( projectDir, "gradlew" ).exists(), equalTo( true ) );
         assertThat( new File( projectDir, "gradlew.bat" ).exists(), equalTo( true ) );
         assertThat( new File( projectDir, "build.gradle" ).exists(), equalTo( true ) );
-        if( FileUtils.removeDir( projectDir ) )
+        if( ! FileUtils.removeDir( projectDir ) )
         {
             System.err.println( "Unable to remove file. Why???" );
         }


Mime
View raw message