polygene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nic...@apache.org
Subject [25/50] [abbrv] zest-qi4j git commit: QI-318 Fixed ValueCompositeSerializationTest for JDK8
Date Fri, 17 Apr 2015 16:05:45 GMT
QI-318 Fixed ValueCompositeSerializationTest for JDK8


Project: http://git-wip-us.apache.org/repos/asf/zest-qi4j/repo
Commit: http://git-wip-us.apache.org/repos/asf/zest-qi4j/commit/3f9ed143
Tree: http://git-wip-us.apache.org/repos/asf/zest-qi4j/tree/3f9ed143
Diff: http://git-wip-us.apache.org/repos/asf/zest-qi4j/diff/3f9ed143

Branch: refs/heads/master
Commit: 3f9ed14374b85372c0da4c97fe8ee98b8ee49690
Parents: 087367a
Author: Paul Merlin <paul@nosphere.org>
Authored: Wed Feb 13 18:04:40 2013 +0100
Committer: Paul Merlin <paul@nosphere.org>
Committed: Wed Feb 13 18:04:40 2013 +0100

----------------------------------------------------------------------
 .../value/AbstractValueCompositeSerializationTest.java   | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zest-qi4j/blob/3f9ed143/core/testsupport/src/main/java/org/qi4j/test/value/AbstractValueCompositeSerializationTest.java
----------------------------------------------------------------------
diff --git a/core/testsupport/src/main/java/org/qi4j/test/value/AbstractValueCompositeSerializationTest.java
b/core/testsupport/src/main/java/org/qi4j/test/value/AbstractValueCompositeSerializationTest.java
index ba5cf15..4fadd75 100644
--- a/core/testsupport/src/main/java/org/qi4j/test/value/AbstractValueCompositeSerializationTest.java
+++ b/core/testsupport/src/main/java/org/qi4j/test/value/AbstractValueCompositeSerializationTest.java
@@ -157,6 +157,7 @@ public abstract class AbstractValueCompositeSerializationTest
         AnotherValue anotherValue = valueBuilder.newInstance();
 
         // FIXME Some Control Chars are not supported in JSON nor in XML, what should we
do about it?
+        // Should Qi4j Core ensure the chars used in strings are supported by the whole stack?
         // proto.string().set( "Foo\"Bar\"\nTest\f\t\b" );
         proto.string().set( "Foo\"Bar\"\nTest\t" );
         proto.string2().set( "/Foo/bar" );
@@ -167,7 +168,15 @@ public abstract class AbstractValueCompositeSerializationTest
         proto.localDateTime().set( new LocalDateTime() );
         proto.entityReference().set( EntityReference.parseEntityReference( "12345" ) );
         proto.stringIntMap().get().put( "foo", 42 );
-        proto.stringIntMap().get().put( "bar", 67 );
+
+        // Can't put more than one entry in Map because this test rely on the fact that the
underlying implementations
+        // maintain a certain order but it's not the case on some JVMs. On OpenJDK 8 they
are reversed for example.
+        // This should not be enforced tough as both the Map API and the JSON specification
state that name-value pairs
+        // are unordered.
+        // As a consequence this test should be enhanced to be Map order independant.
+        //
+        // proto.stringIntMap().get().put( "bar", 67 );
+
         proto.stringValueMap().get().put( "foo", anotherValue );
         proto.another().set( anotherValue );
         proto.serializable().set( new SerializableObject() );


Mime
View raw message