Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 88D7B200CAF for ; Thu, 22 Jun 2017 18:12:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 87D8C160BE7; Thu, 22 Jun 2017 16:12:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C669B160BE5 for ; Thu, 22 Jun 2017 18:12:53 +0200 (CEST) Received: (qmail 4247 invoked by uid 500); 22 Jun 2017 16:12:52 -0000 Mailing-List: contact general-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@poi.apache.org Delivered-To: mailing list general@poi.apache.org Received: (qmail 4236 invoked by uid 99); 22 Jun 2017 16:12:52 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jun 2017 16:12:52 +0000 Received: from mail-ot0-f169.google.com (mail-ot0-f169.google.com [74.125.82.169]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id A24F21A04D1 for ; Thu, 22 Jun 2017 16:12:52 +0000 (UTC) Received: by mail-ot0-f169.google.com with SMTP id 95so14392453ott.3 for ; Thu, 22 Jun 2017 09:12:52 -0700 (PDT) X-Gm-Message-State: AKS2vOxOyk8jZ8pCXVKXlUCtgZe7My1BkuECP6HVS9EtpqHlO71o0icv KBVAtAhMeKrf+OPC21e03+YgWpNkHQ== X-Received: by 10.157.82.134 with SMTP id f6mr1472678oth.166.1498147971904; Thu, 22 Jun 2017 09:12:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.80.12 with HTTP; Thu, 22 Jun 2017 09:12:51 -0700 (PDT) Received: by 10.157.80.12 with HTTP; Thu, 22 Jun 2017 09:12:51 -0700 (PDT) In-Reply-To: References: <594B7E9102000034000F181F@mail.rcmp-grc.gc.ca> <594B81DF02000034000F183F@mail.rcmp-grc.gc.ca> From: "Javen O'Neal" Date: Thu, 22 Jun 2017 09:12:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: POI Quick Guide - Drawing Borders correction To: general@poi.apache.org Content-Type: multipart/alternative; boundary="f40304354004afc8c905528ec13d" archived-at: Thu, 22 Jun 2017 16:12:54 -0000 --f40304354004afc8c905528ec13d Content-Type: text/plain; charset="UTF-8" I was thinking something along the lines of moving code snippets in the quick guide to Java files in a folder in poi-examples. Then use Ant, Gradle, or Forrest to import those examples into the HTML quick guide. We'd need some markers in the Java files to indicate the first and last line that should be copied (probably want to exclude the ASL 2.0, imports, supporting code to make the example compile (open a workbook, get a sheet, row and cell, then operate on the cell to show how cell styles work) and any other boiler plate. This probably is beyond what Forrest 0.6 was designed to do... On Jun 22, 2017 08:44, "Javen O'Neal" wrote: > The unit tests force us to keep the the code, test cases, and compiled > examples up to date, but not the quick guides. > > Does anyone have any ideas how to compile the code snippets in the quick > guide to make sure they are still valid throughout POI API changes (as > Alexander discovered here)? > > > On Jun 22, 2017 05:37, "Alexander Riccio" > wrote: > > Sounds good Nick, I've open Bug 61208 to track this. Didn't know if this > was bug tracker worthy but you are right that this way it won't be lost as > it is a trivial correction. > > Thank you! > > Alex > > >>> > *From: * Nick Burch > *To:* Alexander Riccio > *CC:* > *Date: * 2017/06/22 8:28 AM > *Subject: * Re: POI Quick Guide - Drawing Borders correction > On Thu, 22 Jun 2017, Alexander Riccio wrote: > > I just wanted a correction for the POI Quick Guide - Drawing Borders > > section. > > > > Instead of the reference to the PropertyTemplate.Extent.ALL (or other > > Constants), it should be BorderExtent.ALL. > > > > https://poi.apache.org/spreadsheet/quick-guide.html#DrawingBorders > > Any chance you could raise a bug in POI bugzilla for this? > https://bz.apache.org/bugzilla/enter_bug.cgi?product=POI > That way it won't get forgotten, can be tracked, and you'll get notified > once it's fixed! > > Thanks > Nick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@poi.apache.org > For additional commands, e-mail: general-help@poi.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@poi.apache.org > For additional commands, e-mail: general-help@poi.apache.org > > > --f40304354004afc8c905528ec13d--