From dev-return-39790-archive-asf-public=cust-asf.ponee.io@poi.apache.org Wed Mar 28 05:34:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9AA9718064E for ; Wed, 28 Mar 2018 05:34:03 +0200 (CEST) Received: (qmail 26294 invoked by uid 500); 28 Mar 2018 03:34:02 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 26279 invoked by uid 99); 28 Mar 2018 03:34:01 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2018 03:34:01 +0000 Received: from mail-yw0-f178.google.com (mail-yw0-f178.google.com [209.85.161.178]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 10EBF1C2E for ; Wed, 28 Mar 2018 03:34:00 +0000 (UTC) Received: by mail-yw0-f178.google.com with SMTP id r29so344650ywa.12 for ; Tue, 27 Mar 2018 20:34:00 -0700 (PDT) X-Gm-Message-State: AElRT7GN9gHqm3HzwEwbBztCT/xq+oIUbJChnlcp/cuFke69oc2opdaL 9ANggnIQLGSKyLXMf2UxXLa/CoEy6R+6RWzFFQo= X-Google-Smtp-Source: AIpwx4/kzrzDXmv8bXXO4IMUaxZetYeACU8UBWCnbMnFIrmHDbwzQDHiG7l9GWMm9Z6tlWGjCbV57lYnjZACUgAF4B8= X-Received: by 10.129.77.7 with SMTP id a7mr1165322ywb.483.1522208040181; Tue, 27 Mar 2018 20:34:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Javen O'Neal" Date: Wed, 28 Mar 2018 03:33:49 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Adding a function or two... To: POI Developers List Content-Type: multipart/alternative; boundary="001a1140bc768267ae056870adad" --001a1140bc768267ae056870adad Content-Type: text/plain; charset="UTF-8" HSSF and SS Common tests live here: https://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ XSSF and SS Common tests live here: https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ We separated the tests because HSSF code is compiled and tested without providing ooxml-schema.jar or poi-ooxml-schema.jar on the class path. This way we can guarantee that poi.jar doesn't require ooxml as a dependency, to keep projects small where they're only using the binary formats. On Tue, Mar 27, 2018, 20:09 Blake Watson wrote: > I was just scouring the whole project for XSSFWorkbook and not finding > nearly as much as I thought. > > How does one properly add to functionMetaData.txt? > > On Tue, Mar 27, 2018 at 6:38 PM, Greg Woolsey > wrote: > > > Tests in that package are run in a context without the xssf code. Xssf > > specific tests need to go in a different location. I don't have it on my > > phone, but some searching should reveal them, the naming conventions are > > strong. > > > > On Tue, Mar 27, 2018, 17:45 Blake Watson wrote: > > > > > The tests seem to be mostly HSSF based. Is that right? (I guess it > > > shouldn't matter?) > > > > > > On Mon, Mar 26, 2018 at 9:45 AM, Blake Watson > > > wrote: > > > > > > > Yeah, I was gonna use the Git. > > > > > > > > On Sun, Mar 25, 2018 at 11:04 PM, Dominik Stadler < > > > dominik.stadler@gmx.at> > > > > wrote: > > > > > > > >> Hi, > > > >> > > > >> Tests are part of the published sources in separate directories > under > > > >> "src", for functions mostly under "src/testsources", e.g. > > > >> src/testcases/org/apache/poi/ss/formula/functions seems a good place > > for > > > >> unit-tests that cover specific functions. > > > >> > > > >> Maybe also good if you use either the SVN or Git repository > directly, > > > then > > > >> it is easier to contribute changes as patch or pull-request. > > > >> > > > >> See https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac > > > >> he.org_subversion.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=X2uDFTHTp5eWfrHJql4lFvqbKN_g > > > >> LO7ywUomDopdFrs&e= and > > > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__poi.apac > > > >> he.org_howtobuild.html&d=DwIBaQ&c=dmLomitc30UP5j2qU8E1rg&r=p > > > >> 42pHJHEwFZOHtVFHKJUdL2fYbroN33stXXb3Psthjw&m=1DnAqaPgydsOffy > > > >> pXYLDcv8KsRHlBIdBDu0cTZj2ve0&s=5Y3qC-4XYROiktL9qO-JjkVJMUqN > > > >> 87GDNNpu7RkO50Q&e= for working with the code, > > > >> > > > >> Thanks... Dominik. > > > >> > > > >> > > > >> > > > >> On Sat, Mar 24, 2018 at 1:56 AM, Blake Watson < > blake.watson@pnmac.com > > > > > > >> wrote: > > > >> > > > >> > I was going to try adding functions to POI (IFNA seems like a > likely > > > >> first > > > >> > shot). I've imported the sources from the ZIP (NetBeans) and I can > > > build > > > >> > and run tests. But I don't see where the source code for the tests > > is. > > > >> (I > > > >> > assume I start with the tests...) > > > >> > > > > >> > Also open to any suggestions for...whatever. > > > >> > -- > > > >> > > > > >> > *Blake Watson* > > > >> > > > > >> > *PNMAC* > > > >> > Application Development Manager > > > >> > 5898 Condor Drive > > > >> > Moorpark, CA 93021 > > > >> > (805) 330.4911 x7742 > > > >> > blake.watson@pnmac.com > > > >> > www.PennyMacUSA.com > > > >> > > > > >> > > > > > > > > > > > > > > > > -- > > > > > > > > *Blake Watson* > > > > > > > > *PNMAC* > > > > Application Development Manager > > > > 5898 Condor Drive > > > > Moorpark, CA 93021 > > > > (805) 330.4911 x7742 > > > > blake.watson@pnmac.com > > > > www.PennyMacUSA.com > > > > > > > > > > > > > > > > -- > > > > > > *Blake Watson* > > > > > > *PNMAC* > > > Application Development Manager > > > 5898 Condor Drive > > > Moorpark, CA 93021 > > > (805) 330.4911 x7742 > > > blake.watson@pnmac.com > > > www.PennyMacUSA.com > > > > > > > > > -- > > *Blake Watson* > > *PNMAC* > Application Development Manager > 5898 Condor Drive > Moorpark, CA 93021 > (805) 330.4911 x7742 > blake.watson@pnmac.com > www.PennyMacUSA.com > --001a1140bc768267ae056870adad--