poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] poi pull request #79: Remove the method invocation of toString on a string.
Date Sat, 14 Oct 2017 19:06:54 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/poi/pull/79

    Remove the method invocation of toString on a string.

    Calling String.toString() is just a redundant operation. Just use the String.
    http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/poi trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit 28e706c86187d033619c9590d48b16778535f88f
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-12T21:16:12Z

    Remove the method invocation of toString on a string.
    
    Calling String.toString() is just a redundant operation. Just use the String.
    http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message