poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javen O'Neal" <one...@apache.org>
Subject Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.
Date Mon, 16 Oct 2017 01:36:24 GMT
Looks like all of the String.toString() calls have been removed. I added
this to the forbidden APIs list in r1812239 to eliminate this problem from
recurring.

On Oct 15, 2017 17:42, "Javen O'Neal" <onealj@apache.org> wrote:

We can probably add String.toString() to forbidden APIs to make sure there
aren't other usages of String.toString and that this stays fixed in the
future. Even if String.toString gets compiled out and therefore doesn't
affect library performance,  it could be confusing for someone reading the
code.

Are there any reasons to keep String.toString() usages? Perhaps
String.toString(Locale).

On Oct 15, 2017 13:34, "asfgit" <git@git.apache.org> wrote:

> Github user asfgit closed the pull request at:
>
>     https://github.com/apache/poi/pull/79
>
>
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message