poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pjfanning <...@git.apache.org>
Subject [GitHub] poi pull request #62: [Bug-60422] fix issue with number formatting in German...
Date Sat, 01 Jul 2017 10:32:05 GMT
GitHub user pjfanning opened a pull request:

    https://github.com/apache/poi/pull/62

    [Bug-60422] fix issue with number formatting in German locale

    Initial stab at fixing this issue - needs plenty of extra testing.
    
    * DataFormatter should set the LocaleUtils user locale to match the DataFormatter locale
if set (and if LocaleUtils does not have an explicit locale set already)
    * org.apache.poi.ss.format.CellNumberFormatter has a lot of hardcoding about commas for
grouping separators and dots for decimal separators - should use DecimalFormatSymbols class
    * org.apache.poi.ss.format.CellNumberFormatter also applies the separator from the format
string but my understanding is that "#,##0.00" means to apply locale specific separators,
that the '.' is assumed to mean apply locale specific decimal separator as opposed to specifically
apply '.' as the decimal separator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pjfanning/poi Bug-60422b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit 60e0f78eaf18881b43856c31ce00cfaca031104b
Author: pj.fanning <pj.fanning@workday.com>
Date:   2017-07-01T10:28:39Z

    [Bug-60422] fix issue with number formatting in German locale

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message