poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60898] XSSFColor's getARGB() method returns a wrong color value when a workbook has a custom indexed color
Date Thu, 25 May 2017 21:32:51 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60898

--- Comment #6 from Greg Woolsey <gwoolsey@apache.org> ---
Solution 2 sounds worse than it looks, to my initial take.  Constructor calls
of all sorts are almost entirely from contexts that would have access to the
workbook styles, and could pass in what is needed.  The remaining paths can be
documented as lacking custom color index support.

XSSFColor itself can defensively check as needed and fall back on the current
behavior when the custom index info is missing.

Further, we can add some more support to StylesTable to avoid repeated calls
into the CT* classes, as that is always expensive, and color lookups can be
done thousands of times (or a few more orders of magnitude) in processing
formatting for a single workbook.

I'll see if I have some time to dig in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message