Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5638D200C2C for ; Fri, 3 Mar 2017 15:35:14 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 54CF8160B6D; Fri, 3 Mar 2017 14:35:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9C5E0160B57 for ; Fri, 3 Mar 2017 15:35:13 +0100 (CET) Received: (qmail 63944 invoked by uid 500); 3 Mar 2017 14:35:12 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 63932 invoked by uid 99); 3 Mar 2017 14:35:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Mar 2017 14:35:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 50B5D1857AE for ; Fri, 3 Mar 2017 14:35:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.347 X-Spam-Level: X-Spam-Status: No, score=-2.347 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8XYlohhZ9RoS for ; Fri, 3 Mar 2017 14:35:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6ADAB5F58E for ; Fri, 3 Mar 2017 14:35:11 +0000 (UTC) Received: from asf-bz1-us-mid.priv.apache.org (nat1-us-mid.apache.org [23.253.172.122]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTPS id E4D0EE00C4 for ; Fri, 3 Mar 2017 14:35:10 +0000 (UTC) Received: by asf-bz1-us-mid.priv.apache.org (ASF Mail Server at asf-bz1-us-mid.priv.apache.org, from userid 33) id 061AE60D52; Fri, 3 Mar 2017 14:35:09 +0000 (UTC) From: bugzilla@apache.org To: dev@poi.apache.org Subject: [Bug 60795] Add enum for msg types Date: Fri, 03 Mar 2017 14:35:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: HSMF X-Bugzilla-Version: 3.16-dev X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: tallison@mitre.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@poi.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bz.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 archived-at: Fri, 03 Mar 2017 14:35:14 -0000 https://bz.apache.org/bugzilla/show_bug.cgi?id=3D60795 --- Comment #4 from Tim Allison --- Javen, I'm sorry for my delay. > Will we be able to remove/replace String getMessageClass() with getMessag= eClassEnum()? Yes, and then back again much later, right? The user can still get the underlying StringChunk if they want the literal chunk. > The enum version calls the string version (for now). This would mean we'd= have to move some code around or rename public String getMessageClass () t= o private String getMessageClassString(). I fixed that. Thank you. > mainChunks.getMessageClass() looks like this method is part of an interfa= ce. Have we deprecated that method in the interface and all implementing cl= asses? I don't think we should. That is a low-level call that returns the StringChunk. Advanced users should have access to that. --=20 You are receiving this mail because: You are the assignee for the bug.= --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org