poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60826] Add initial support for SAX-like read-only .xlsb parser
Date Fri, 17 Mar 2017 04:34:46 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60826

--- Comment #5 from Javen O'Neal <onealj@apache.org> ---
XSSFBRichTextString: add @org.apache.poi.util.NotImplemented annotation to
stubbed functions that haven't been implemented yet.
Global: add @since 3.16-beta3 javadoc to all new classes
XSSFBCellHeader: formatAddressAsString can be implemented using new
CellAddress(int row, int col).formatAsString().
XSSFBSharedStringsTable: change constructor Javadoc to @since 3.16-beta3.
XSSFBSharedStringsTable: should getItems return an unmodifiableList or a copy
of the list?
XSSFBCellRange: "public static final int length" is the standard modifier
order. See http://stackoverflow.com/a/10299123/2683399 for order
XSSFBCellRange: this should have tighter integration with
o.a.p.ss.util.AreaReference in the future, but AreaReference probably needs
some cleanup first.
XSSFBCommentsTable: should the natural ordering of CellAddresses be implemented
into the CellAddress class itself instead as CellAddressComparator inner class?
Or perhaps as a standalone class if both row-major and column-major ordering is
needed.
XSSFBCommentsTable: add a comment to CellAddressComparator that this
implementation is row-major ordering
XSSFEventBasedExcelExtractor: any reason for elevating visibility from private?
Was this just a quick fix to get the code to work? Is the performance
acceptable if you add accessors to private members? If not, does protected
work?
XSSFBEventBasedExcelExtractor: should we log caught and suppressed exceptions
to the POILogger rather than stderr?
TestExtractorFactory: replace assertTrue(String.contains(String)) with
POITestCase.assertContains(String haystack, String needle)
TestXSSFBReader: import assertContains from POITestCase rather than redefining.
TestXSSFBEventBasedExcelExtractor: testShapes uses String.indexOf(String) > -1.
Consider using or adding something to POITestCase to make the purpose clearer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message