poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60795] Add enum for msg types
Date Fri, 03 Mar 2017 14:35:09 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60795

--- Comment #4 from Tim Allison <tallison@mitre.org> ---
Javen,
  I'm sorry for my delay.

> Will we be able to remove/replace String getMessageClass() with getMessageClassEnum()?

Yes, and then back again much later, right?  The user can still get the
underlying StringChunk if they want the literal chunk.

> The enum version calls the string version (for now). This would mean we'd have to move
some code around or rename public String getMessageClass () to private String getMessageClassString().

I fixed that.  Thank you.

> mainChunks.getMessageClass() looks like this method is part of an interface. Have we
deprecated that method in the interface and all implementing classes?

I don't think we should.  That is a low-level call that returns the
StringChunk.  Advanced users should have access to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message