poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60787] CellUtil.class with print strings
Date Wed, 01 Mar 2017 08:09:49 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60787

Javen O'Neal <onealj@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEEDINFO                    |RESOLVED

--- Comment #3 from Javen O'Neal <onealj@apache.org> ---
The logging code did exactly what it was intended to do--notify the user that
the current code will not work in a future version of POI.

https://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java?revision=1760630&view=markup#l519

I added these INFO-level warnings to the POI logger to let users know that
CellUtil will switch to using enums in the future. See bug 59836 if you're
curious. Enums are safer, faster (checked at compile time instead of
runtime--if checked at all), require less code, and give more informative error
messages (enum name instead of integer code), and easier to use. They also make
the POI API more flexible since users are unable to hard-code integer literals
in place of enums.
Finally, it makes the method signatures easier to read.

If you have code that is tripping these warnings that is originating from POI
code, post it here so we can fix it (it may not be possible without breaking
backwards compatibility, in which case we'll defer those changes).

If the code that is tripping these warnings comes from your code, consider
upgrading that code to use enums.

You could also choose to ignore the POI log, change the logger level
(log.check), or have your logger write to a different destination if it's
causing you problems. Suppressing the problem now will make it more difficult
to update down the road. Your call, but not a call that I would want to make
for all users. Maybe someone else wants those warnings written to the log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message