poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method
Date Fri, 17 Feb 2017 10:26:31 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Javen O'Neal <onealj@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34759|0                           |1
        is obsolete|                            |

--- Comment #8 from Javen O'Neal <onealj@apache.org> ---
Created attachment 34762
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34762&action=edit
The patch corresponding to attachment 34759 against the code from 3.15-final

(In reply to zakim from comment #7)
> The file shows the changes added to the existing file, compared to poi version > 3.15-FINAL
as stated in the version field.
The version field is sometimes updated when an unfixed bug is still present in
a later build, so it's better to explicitly state in a comment what the base
rev for a file is. Even better is to submit a patch, which includes the rev if
the patch was generated by Subversion.
It's probably a good idea to check out trunk anyways so that you can open the
project in Eclipse or other IDE, make your changes, and know immediately
whether there are compile-time errors with your changes.

> I haven't checked out the entire project to send only the differences.
You can perform a sparse svn checkout of POI if you don't want to wait the 10
minutes it takes to check out the trunk or one of the release tags. You could
also save the original file and modified file and use any diffing program to
generate a patch file (Linux/Mac: diff, Windows: TortoiseSVN, TortoiseGit)

> It was only a suggestion to make poi more usable which means in my opinion: 
> a more usable framework should be easy to use, with less coding.
> If you need to write ten classes using the poi framework then you better
> write the whole function without using poi.
This is the part that I am confused about. How does the addition of an empty
endSheet() method make it easier for someone to use POI? Did I correctly
receive your patch file? Was there really only an addition of 3 lines?

The only other references I see to endSheet within the POI source code and
website is in BigGridDemo. Is this the inspiration for this bug?

I am genuinely interested in trying to make POI easier for people to use, but
I'm not convinced that the contributions so far accomplish that. Am I missing
some other files that have some useful behavior when the endSheet() event is
reached?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message