poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murphy, Mark" <murphym...@metalexmfg.com>
Subject RE: [Bug 60504] Add to public API POIXMLDocumentPart.removeRelation(POIXMLDocumentPart part)
Date Wed, 21 Dec 2016 21:07:20 GMT
This is a great point Greg. Though drawings are part of the DrawingML spec, all documents currently
handle it separately as we don't have a DrawingML package. We would probably benefit from
having separate packages for shared components of the spec like DrawingML, and Charts.

-----Original Message-----
From: bugzilla@apache.org [mailto:bugzilla@apache.org] 
Sent: Wednesday, December 21, 2016 2:00 PM
To: dev@poi.apache.org
Subject: [Bug 60504] Add to public API POIXMLDocumentPart.removeRelation(POIXMLDocumentPart
part)

https://bz.apache.org/bugzilla/show_bug.cgi?id=60504

Greg Woolsey <greg.woolsey@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Greg Woolsey <greg.woolsey@gmail.com> --- While we could make it
public, that would also open the door to lots of ways to completely break a workbook.  I'd
prefer to see a higher level API for replacing one image with another that would handle these
details internally in a consistent manner, with lots of unit tests.

Patches are always welcome, as waiting for a volunteer to have the time and inclination to
add a specific feature can take some time :)  Short of a patch, a robust discussion of what
exactly an API improvement might look like, including test vectors, is still helpful.

For example, it may be that different document types need to handle image replacement differently.
 I haven't dug in to how the different formats do it, but cell vs. slide vs. paragraph anchor
references seem like one area that may be different.  Ideally there should be some consistency
between document types for image replacement, and perhaps some checks as well if there are
constraints or decisions needed when images differ in size, for example.

(In reply to Aurélien from comment #0)
> Currently the method 
> POIXMLDocumentPart.removeRelation(POIXMLDocumentPart
> part) is protected.
> Would it be possible to change the visibility of this method to public?
>

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org

Mime
View raw message