poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thelmstedt <...@git.apache.org>
Subject [GitHub] poi pull request #38: BUG-60288: removes defensive copy for internal relatio...
Date Fri, 21 Oct 2016 06:31:55 GMT
GitHub user thelmstedt opened a pull request:

    https://github.com/apache/poi/pull/38

    BUG-60288: removes defensive copy for internal relationships usage

    Fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=60288
    
    Since we're not returning `_relationships` from this method we can just use it directly.
Avoids quadratic slowdowns when this is (transitively/directly) used in a loop of these relationships.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thelmstedt/poi trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 2745599fa0cb9c536e6fb2dfdbaa7d3585605460
Author: Tim Helmstedt <tim.helmstedt@gmail.com>
Date:   2016-10-21T06:25:29Z

    BUG-60288: removes defensive copy for internal relationships usage

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message