poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60271] New: Handle collisions of Macro names
Date Tue, 18 Oct 2016 16:52:02 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60271

            Bug ID: 60271
           Summary: Handle collisions of Macro names
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POIFS
          Assignee: dev@poi.apache.org
          Reporter: tallison@mitre.org

While working on [Bug 59858], I found that there can be multiple copies of a
macro with the same name.  Given that we're storing macros only by the macro
name, this means that we might overwrite or skip macros with the same name.

If we want to maintain all macros, I propose that we store them as
macroDir.getPath()+"\\"+macroName.

In 59858's test file, we'd have:

\_VBA_PROJECT_CUR\VBA\ThisWorkbook
\_VBA_PROJECT_CUR\VBA\SupportFunctions
\_VBA_PROJECT_CUR\VBA\ReferencesAndConstants
\_VBA_PROJECT_CUR\VBA\frmPageCreation
\_VBA_PROJECT_CUR\VBA\Sheet4
\_VBA_PROJECT_CUR\VBA\Sheet6
\_VBA_PROJECT_CUR\VBA\Sheet7
\_VBA_PROJECT_CUR\VBA\Sheet5
\_VBA_PROJECT_CUR\VBA\Sheet2
\_VBA_PROJECT_CUR\VBA\Sheet3
\_VBA_PROJECT_CUR\VBA\Sheet1
\MBD00082648\_VBA_PROJECT_CUR\VBA\Sheet2
\MBD00082648\_VBA_PROJECT_CUR\VBA\ThisWorkbook
\MBD00082648\_VBA_PROJECT_CUR\VBA\Sheet3
\MBD00082648\_VBA_PROJECT_CUR\VBA\Sheet1

I'll leave this open for comment for a few days.  I'm not sure this is the best
option...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message