poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59853] XSSFSheet PivotTable support doesn't support Structured Reference (table) sources
Date Mon, 08 Aug 2016 04:24:43 GMT

--- Comment #5 from Greg Woolsey <greg.woolsey@gmail.com> ---
Created attachment 34110
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34110&action=edit
Additional pivot table base data options - Named Range and Table

After more vacations than I thought we could pull off in one summer, I finally
got this ready.  There were some interesting wrinkles down in the weeds, but
nothing that affected a broad area of the API.

I've refactored the TestXSSFPivotTable class into an abstract base class with
the tests, and two concrete subclasses with the setup.  Each class sets up the
pivot tables differently, one with area references as before, and one with
names (named ranges).  Both pass with no changes, as they should.

I'm open to refactoring ideas for XSSFPivotTable.createSourceReferences() - it
now has two mutually exclusive parameters, not my favorite pattern.  However,
it's protected, and called from exactly one place, which is also overloaded
that way, a private method, XSSFSheet.createPivotTable(...). 

Since those are internal, I was OK with it.

You are receiving this mail because:
You are the assignee for the bug.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

View raw message