poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59799] build.xml should not run tests as part of the 'compile-all' target
Date Tue, 05 Jul 2016 20:17:47 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=59799

--- Comment #7 from Sebb <sebb@apache.org> ---
(In reply to Andreas Beeker from comment #5)
> (In reply to Sebb from comment #4)
> > If the unit tests are run against the lite jar rather than the merged input,
> > this should show up any problems. This would check that the jar really did contain
> > everything required.
> 
> Nope ... neither the current nor your proposed workflow guarantees that all
> xmlbeans fragments are included - e.g. we had problems with empty XSLFTables
> for quite a while and I actually don't know what (test) solved it, but back
> then the test were successful and the tables empty ...

The point is that it would at least show that the unit tests could run against
the lite jar.

> > (In reply to David North from comment #3)
> > > What's the concrete problem here - the time taken to run compile-ooxml-lite,
> > > or something else?
> > 
> > The time taken to run the target, and the fact that it is rerun even if
> > there has been no change to the sources.
> 
> When developing unit tests, I don't have a problem with that - I just run
> the unit test in question. Before check-in, I wait the 10 minutes to run the
> tests - in relation to the time taken to check/develop a feature this is
> minimal in my view.
> 
> Can you be a bit more precise why you want to speed up vs. making the build
> more complicate?

When I was trying to work out what was happening with Bug 59786 the obvious way
to test the problem was to build the jars and then run them with the
appropriate command-line. Waiting 2-3 mins instead of 20 secs or so is a pain
when making incremental changes. It's a waste of resources (human and
computer).

Besides, I don't believe that the build needs to be more complicated; it just
needs some minor re-arrangement.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message