Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0A8A200B38 for ; Fri, 24 Jun 2016 04:14:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF2C8160A68; Fri, 24 Jun 2016 02:14:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6AEE9160A59 for ; Fri, 24 Jun 2016 04:14:07 +0200 (CEST) Received: (qmail 16541 invoked by uid 500); 24 Jun 2016 02:14:06 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 16530 invoked by uid 99); 24 Jun 2016 02:14:06 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jun 2016 02:14:06 +0000 Received: from asf-bz1-us-mid.priv.apache.org (nat1-us-mid.apache.org [23.253.172.122]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPS id 69AF51A02EE for ; Fri, 24 Jun 2016 02:14:06 +0000 (UTC) Received: by asf-bz1-us-mid.priv.apache.org (ASF Mail Server at asf-bz1-us-mid.priv.apache.org, from userid 33) id A72CC609E1; Fri, 24 Jun 2016 02:14:04 +0000 (UTC) From: bugzilla@apache.org To: dev@poi.apache.org Subject: [Bug 59748] [PATCH] Remove use of obsolete Hashtable class Date: Fri, 24 Jun 2016 02:14:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: POI Overall X-Bugzilla-Version: 3.15-dev X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: onealj@apache.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@poi.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bz.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 archived-at: Fri, 24 Jun 2016 02:14:08 -0000 https://bz.apache.org/bugzilla/show_bug.cgi?id=59748 --- Comment #1 from Javen O'Neal --- Looks okay to me. We should add key-value generic type when missing. Public methods should return a new map or wrap the map with Collections.unmodifiableMap. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org