poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58787] [patch] Border utility to set cell styles around a range of cells
Date Tue, 14 Jun 2016 00:39:02 GMT

--- Comment #36 from Mark Murphy <jmarkmurph@yahoo.com> ---
(In reply to comment #27)
>  private boolean borderIsNotSet(CellAddress cell, String borderDirection) {
>      Object borderLineStyle = getTemplateProperty(cell, borderDirection);
> -    return (borderLineStyle == null);
> +    return (borderLineStyle == null) || (borderLineStyle == BorderStyle.NONE);
>  }

Changed this to borderIsSet() because I generally do not like negative logic
flags. That is, booleans with something like Not in the name. These flags tend
to map a value like Found to False, and Not Found to True. Is the object
notFound? Yes the object is notFound, or No the object is not notFound. Too
many nots. I prefer to put the negation in the operator.

You are receiving this mail because:
You are the assignee for the bug.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

View raw message