poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58787] [patch] Border utility to set cell styles around a range of cells
Date Mon, 13 Jun 2016 23:10:53 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=58787

--- Comment #35 from Mark Murphy <jmarkmurph@yahoo.com> ---
(In reply to comment #27)
> When adding a border color, if a border line style is not set in the property
> template, the code sets it. Was there any reason for using drawTopBorder rather
> than directly adding the property?

Now that I can look at my code, this is a style thing. While it would work to
just add the code here, if a bug were to rear it's ugly head in
drawTopBorder(), we would potentially have two places to make the correction.
One in drawTopBorderColor(), and one in drawTopBorder(). Notice that there is
already one side case where we are removing a border by setting it to NONE
which adds extra code. Granted the need to ensure a border exists to apply a
color to would not ever be setting the top border to NONE, but say another side
case appears? My time programming RPG has given me a strong appreciation for
the DRY concepts because I frequently experience what happens when that isn't
followed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message