poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56469] [PATCH] patch for XWPF to support adding comments
Date Fri, 19 Feb 2016 13:54:41 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=56469

sperl.simon@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31568|0                           |1
        is obsolete|                            |
                 CC|                            |sperl.simon@gmail.com

--- Comment #2 from sperl.simon@gmail.com ---
Created attachment 33570
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33570&action=edit
a .tar.gz generated using "ant -f patch.xml" for supporting adding and editing
comments

based on a mixture of the previous patch, logic from footnote and sweat.

In general a bit confused when to use create/add/get I tried to be consistent
but I am afraid there is not much precedent.

I also think there is a real need for an AbstractBody class, the code
duplication is getting pretty strong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message