poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javen O'Neal" <javenon...@gmail.com>
Subject Re: Please review #54916
Date Thu, 31 Dec 2015 23:25:57 GMT
For deprecating features, I'd mark them as "@deprecated in POI 3.14"
rather than "@deprecated by POI 3.16", We could add "remove by POI
3.16", but we're probably not going to be on top of it enough to
remove deprecated features exactly 2 major releases after deprecation.
We may want to have a general note on the website about our
deprecation-plus-2-releases removal process, so it's not just
information floating around in the mail list. If you want to be
explicit about the target removal release or deviate from the
deprecation+2 rule, you could say "@deprecated in POI 3.14, scheduled
for removal in POI 3.16", which is easier to understand than
"@deprecated by POI 3.16"

Could you pull out the unrelated changes (such as deleting the
@SuppressWarnings("deprecation") for getXYZArray() array access)?

@@ -451,10 +460,11 @@
         CTDrawing ctDrawing = getCTDrawing();
         if (ctDrawing != null) {
             // Search the referenced drawing in the list of the
sheet's relations
-            for (POIXMLDocumentPart p : getRelations()){
+            for (RelationPart rp : getRelationParts()){
+                POIXMLDocumentPart p = rp.getDocumentPart();
                 if (p instanceof XSSFDrawing) {
                     XSSFDrawing dr = (XSSFDrawing)p;
-                    String drId = dr.getPackageRelationship().getId();
+                    String drId = rp.getRelationship().getId();

Could you create a variable or comment to describe the what type of
object rp.getRelationship() is?

On Thu, Dec 31, 2015 at 3:27 AM, Andreas Beeker <kiwiwings@apache.org> wrote:
> Hi,
>
> I'd like to ask one of the PMCs to review my patch for #54916.
> The reason is, that it affects not only XSLF, but all OOXML modules and it's kind of
a base change.
> For more information, have a look at the bugzilla entry.
>
> As I'll be on a hang gliding trip from 01-10.01.16, I might not have WI-FI access to
respond
> in time, and will take care about the issues afterwards.
>
> Have a "Happy new year"!
>
> Andi.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message