poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javen O'Neal" <javenon...@gmail.com>
Subject Re: DataFormatter vs. org.apache.poi.ss.format classes
Date Fri, 27 Nov 2015 03:20:34 GMT
I'm all for reducing the number of lines of code. If you could consolidate
the two classes or have one class delegate to another, that's a step in the
right direction
On Nov 26, 2015 4:53 PM, "Andreas Beeker" <kiwiwings@apache.org> wrote:

> Hi,
>
> about 5-6 days ago, I just wanted to fix a few unnecessary cast, but now
> I'm in the middle
> of cell formatting hell :)
>
> Would it be ok, if DataFormatter delegates much of its logic to the
> org.apache.poi.ss.format
> classes?
>
> Currently, I'm struggling with CellNumberFormatter and noticed that the
> test in TestDataFormatter.testFractions
> assume, that a lot of formatting details are skipped, whereas
> CellNumberFormatter try to
> provide most corner cases.
> Is there a reason for the simplified handling in DataFormatter or is it
> just legacy?
>
> Andi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message