Mailing-List: contact dev-help@poi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "POI Developers List" <dev@poi.apache.org>
Subject: Re: svn commit: r1709427 -
 /poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java
To: dev@poi.apache.org
References: <20151019145531.01C6B3A0032@svn01-us-west.apache.org>
 <036001d10a93$cd0e6d00$672b4700$@thetaphi.de>
From: Dustin Spicuzza <dustin@virtualroadside.com>
Openpgp: url=http://www.virtualroadside.com/key.asc
Message-ID: <56252F2E.7050407@virtualroadside.com>
Date: Mon, 19 Oct 2015 13:58:06 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <036001d10a93$cd0e6d00$672b4700$@thetaphi.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="UWVOSPOi9EARvMOeUbILLrhxVcXnurGUG"

--UWVOSPOi9EARvMOeUbILLrhxVcXnurGUG
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Thanks, I was originally using Collections.emptyIterator(), but that's on=
ly available in Java 7+. I'll do it your way, that sounds easier anyways.=
 :)=20

Dustin

On 10/19/2015 1:30 PM, Uwe Schindler wrote:
> Just unrelated to the original fix:
>=20
> According to checks, the EmptyIterator should throw NoSuchElementExcept=
ion.
> But I would remove the impl completely! It is much simpler to just retu=
rn Collections.emptySet().iterator() when empty iterators are required; t=
his is also just returning a static singleton, so no speed improvement at=
 all!
>=20
> Uwe
>=20
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>=20
>=20
>> -----Original Message-----
>> From: virtuald@apache.org [mailto:virtuald@apache.org]
>> Sent: Monday, October 19, 2015 4:56 PM
>> To: commits@poi.apache.org
>> Subject: svn commit: r1709427 -
>> /poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/Combi
>> nedIterable.java
>>
>> Author: virtuald
>> Date: Mon Oct 19 14:55:30 2015
>> New Revision: 1709427
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1709427&view=3Drev
>> Log:
>> XDGF: fix jdk < 1.8 compat
>>
>> Modified:
>>
>> poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/Combin
>> edIterable.java
>>
>> Modified:
>> poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/Combin
>> edIterable.java
>> URL:
>> http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/x=
d
>> gf/usermodel/section/CombinedIterable.java?rev=3D1709427&r1=3D1709426&=
r2
>> =3D1709427&view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> ---
>> poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/Combin
>> edIterable.java (original)
>> +++
>> poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/Combi
>> +++ nedIterable.java Mon Oct 19 14:55:30 2015
>> @@ -17,7 +17,6 @@
>>
>>  package org.apache.poi.xdgf.usermodel.section;
>>
>> -import java.util.Collections;
>>  import java.util.Iterator;
>>  import java.util.Map.Entry;
>>  import java.util.NoSuchElementException; @@ -35,14 +34,21 @@ public
>> class CombinedIterable<T> impleme
>>
>>      private static final class EmptyIterator<T> implements Iterator<T=
> {
>>
>> +        @Override
>>          public boolean hasNext() {
>>              return false;
>>          }
>>
>> +        @Override
>>          public T next() {
>>              return null;
>>          }
>>
>> +        @Override
>> +        public void remove() {
>> +            throw new UnsupportedOperationException();
>> +        }
>> +
>>      }
>>
>>      public CombinedIterable(SortedMap<Long, T> baseItems,
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
>> For additional commands, e-mail: commits-help@poi.apache.org
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>=20


--=20
Innovation is just a problem away


--UWVOSPOi9EARvMOeUbILLrhxVcXnurGUG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (MingW32)

iQIcBAEBAgAGBQJWJS8zAAoJENXGN37eUHhrDdsP/iMkeI9mGFpY7rrhEFaqkZjs
C4f9SsNc9vQTvsdzXeJn8uai+KXlsImhw7BBfyLlmxajjgWub5R7djpMkUVyZDQv
xEPaRq9Km+vrRbkJHF9TT2xt9BoEY4tp1pkb8OXv91jSZ2nJJmgrQDT+/c+Edb2j
uWXuHjCOHPp7GaMAVzhAoaGMVFT9zZONGbMTKqMjA2ZzXPvtOXDosR/HDFiUhfEC
zINTpxGsRCKi8Fo0qX1J2Q9Xb+LYD7nki6l6PjT0bP6g4pDnxzyJngyxZfM6BVJ5
mXgGWddzPFLDzzco42LzmObaZKY10QQ6uJmvH3XAZKWV3FsSUPhCABcZb1EUSvOh
YH7mbGxVXUfYl5FZqPwDS6RhTx/WS4rOOPNPod1bD+t+xVYEHlOk5hlR3FXzFOPU
ikVtRYYKF+iixAI/9ygk8oai/SdSy6FoMDVEC/D2EWcIY7rH/9PcL5+qu0mI6Z/U
K9G2c2faEze6z5f/WQ5R/S4s1y9H3IkLAA/XF0RkBeLGnDeeJ8d/v6GAUSIgtb1T
HDoTJ20V48WeqhKpajiXilEfHS2FPJqahpJaxVdn9EWx57z7Lc4PD566yVOgN5MY
qe/CJK+XP/TfOEgB8X2yQHF5s2E2D4TQDwZdr8Y/xGWYIRhzzb2rzghXMcVur6I8
YynojIugOJSNdF93Cynm
=Uh+b
-----END PGP SIGNATURE-----

--UWVOSPOi9EARvMOeUbILLrhxVcXnurGUG--