poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58466] New: ColumnHelper.addCleanColIntoCols() loses information in some overlapping-column cases
Date Tue, 29 Sep 2015 17:00:30 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=58466

            Bug ID: 58466
           Summary: ColumnHelper.addCleanColIntoCols() loses information
                    in some overlapping-column cases
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: cmb-apache@corefiling.co.uk

Created attachment 33151
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33151&action=edit
More tests of ColumnHelper, 2 of which fail

I attach a patch adding some more tests of ColumnHelper, 2 of which fail:

* testAddCleanColIntoColsExactOverlap
  * Adds CTCol(min=1, max=1, hidden=true)
  * Adds CTCol(min=1, max=1, bestFit=true)
  * Expected: CTCol(min=1, max=1, hidden=true, bestFit=true)
  * Actual:   CTCol(min=1, max=1, hidden=true)

* testAddCleanColIntoColsNewOverlapsOverhangingLeftNotRightExactRight:
  * Adds CTCol(min=2 max=3 hidden=true)
  * Adds CTCol(min=1 max=3 bestFit=true)
    * Note that a sort happens, meaning 1-3 is encountered first in the combine
operation.
  * Expected: (min=1, max=1, bestFit=true), (min=2, max=3, bestFit=true,
hidden=true)
  * Actual:   (min=1, max=1, bestFit=true), (min=2, max=3, bestFit=true)

We have our own different implementation of a fast column merger which passes
these; it pre-dates trunk's current implementation introduced in r1561435 under
bug 54283. We can look at contributing our replacement if that's easier than
fixing the current implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message