poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56705] [PATCH] XSSFWorkbook.getSheet(String) is slow with many sheets
Date Tue, 19 May 2015 19:14:34 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=56705

Dominik Stadler <dominik.stadler@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Dominik Stadler <dominik.stadler@gmx.at> ---
I'm not sure if this is a big problem in almost all other use cases of POI as
usually there are only a few sheets and getSheet() is not called that often as
well. 

So by optimizing this one specific case we would actually add a bit more to
some other methods and also make the code more complex and harder to maintain.

How many sheets do you have in those workbooks? And how often do you actually
call it? I wouldn't optimize this inside POI if it is simply called much too
often in your case.

Would it maybe be better to solve your specific case here with a small cache in
your code which remembers these sheet-name to index mapping outside of POI core
code and then uses getSheetAt() to have quick access?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message