Return-Path: X-Original-To: apmail-poi-dev-archive@www.apache.org Delivered-To: apmail-poi-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0168B17D9C for ; Mon, 23 Feb 2015 23:04:58 +0000 (UTC) Received: (qmail 86377 invoked by uid 500); 23 Feb 2015 23:04:57 -0000 Delivered-To: apmail-poi-dev-archive@poi.apache.org Received: (qmail 86332 invoked by uid 500); 23 Feb 2015 23:04:57 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 86314 invoked by uid 99); 23 Feb 2015 23:04:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Feb 2015 23:04:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1F316E04D1; Mon, 23 Feb 2015 23:04:57 +0000 (UTC) From: rojotek To: dev@poi.apache.org Reply-To: dev@poi.apache.org Message-ID: Subject: [GitHub] poi pull request: Fixed issue where a zero length libre office doc... Content-Type: text/plain Date: Mon, 23 Feb 2015 23:04:57 +0000 (UTC) GitHub user rojotek opened a pull request: https://github.com/apache/poi/pull/18 Fixed issue where a zero length libre office document with a water mark ... ...image was causing an identifier out of range bug. #### What's this PR do? Changes the min value for the identifier manager in XWPFDocument to be 0, as the included test document had an identifier with value 0. Document Sourced from libre office with a watermark and no text. The newly added testcase will fail if the code change is removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rojotek/poi zero-length-libre-office Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 ---- commit f26748032e13fdaf4c2fd43ba2218ba74e99a330 Author: Rob Dawson Date: 2015-02-23T23:00:18Z Fixed issue where a zero length libre office document with a water mark image was causing an identifier out of range bug. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org