poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 46898] [PATCH] Unexpected Error -60 Circular reference
Date Fri, 02 Jan 2015 21:30:51 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46898

Dominik Stadler <dominik.stadler@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEEDINFO

--- Comment #8 from Dominik Stadler <dominik.stadler@gmx.at> ---
I have changed the tests via r1649122 to also run for XSSF, they run fine
currently so the cases verified for HSSF work fine for XSSF as well already.

For the proposed change to FormulaError to change the error to INVALID_VALUE I
am not sure if this is the right thing to do as it leaves ERROR_CIRCULAR_REF in
some places (e.g. value.getErrorValue()) and changes the error to VALUE_INVALID
in others, obviously I don't know this part of the code well enough to be sure,
but wouldn't we change the error-code in a more central place to have
INVALID_VALLUE everywhere?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message