poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56705] [PATCH] XSSFWorkbook.getSheet(String) is slow with many sheets
Date Tue, 26 Aug 2014 10:47:13 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56705

Chris Boyle <cmb-apache@corefiling.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #2 from Chris Boyle <cmb-apache@corefiling.co.uk> ---
Having just looked at this again: the map is a LinkedHashMap and most of the
required operations are possible using only the map with no worse efficiency
than before (walk the map's values() which is no worse than walking the
previous List).

Unfortunately it all falls down at setSheetOrder(sheetname, pos). With
LinkedHashMap it would have to remove and reinsert every sheet between its
desired position and the end. You would need a kind of LinkedHashMap with the
ability to reorder its internal list. I don't know of one and I'm not sure
adding one and maintaining it would be an improvement over the patch as it
stands.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message