poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56328] FormulaParser is hard-coded to assume a maximum of 65536 rows
Date Fri, 28 Mar 2014 17:46:22 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56328

--- Comment #2 from David North <dtn-asfbugs@corefiling.co.uk> ---
Created attachment 31456
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31456&action=edit
Patch to fix FormulaParser using SpreadsheetVersion

Problematic references:

./org/apache/poi/ss/formula/FormulaParser.java:            if (i<1 || i>65536)
{

./org/apache/poi/ss/util/AreaReference.java:            // Represented
internally as x$1 to x$65536
./org/apache/poi/ss/util/AreaReference.java:        return new
AreaReference(start + "$1:" + end + "$65536");

The attached patch fixes FormulaParser, which turned out to be trivial as
there's already a SpreadsheetVersion in scope.

Fixing AreaReference is a little more involved as the information needs passing
through to the right point. So I think I'll save that treat for next week -
happy weekend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message