poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 55612] Performance improvement (~11% up to ~92%) by adding a cache to HSSFCellStyle.getDataFormatString()
Date Sun, 27 Oct 2013 13:49:16 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=55612

--- Comment #8 from Luca Della Toffola <luca.dellatoffola@inf.ethz.ch> ---
(In reply to Yegor Kozlov from comment #6)
> I realized I was wrong when I wrote about thread unsafety of this patch. We
> really needed synchronization in Bugzilla 55611 because
> DateUtil.isADateFormat(int, String) is static and the state of its cache
> must be synchronized. 
> 

I think you were actually right in the beginning. Even if
HSSFCellStyle.getDataFormatString() is an instance method the cache is static
so we need a static lock to synchronize various threads accessing/updating the
cache.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message