poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darren Roberts <roberts...@yahoo.com>
Subject Re: modify XSSFTestDataSamples.writeOutAndReadBack to write to directory specified by optional sys prop?
Date Mon, 29 Jul 2013 15:13:26 GMT
Sounds like a good idea to me. 




>________________________________
> From: "Allison, Timothy B." <tallison@mitre.org>
>To: POI Developers List <dev@poi.apache.org> 
>Sent: Monday, July 29, 2013 3:51 PM
>Subject: RE: modify XSSFTestDataSamples.writeOutAndReadBack to write to directory specified
by optional sys prop?
> 
>
>Sorry, to clarify, I'd add a function with a different signature:
>
>writeOutAndReadBack(R wb, String testName)
>
>(where testName is used as the name of the file)
>
>Devs could then choose to call that one or the original:
>
>writeOutAndReadBack(R wb) 
>
>
>-----Original Message-----
>From: Allison, Timothy B. [mailto:tallison@mitre.org] 
>Sent: Monday, July 29, 2013 10:40 AM
>To: POI Developers List (dev@poi.apache.org
>Subject: modify XSSFTestDataSamples.writeOutAndReadBack to write to directory specified
by optional sys prop?
>
>POI Dev Community,
>  The patch for 55294 (https://issues.apache.org/bugzilla/show_bug.cgi?id=55294) includes
a handy option to write files to the directory set by the system property "poi.test.xssf.output.dir"
in writeOutAndReadBack.  If the property is not set, it backs off to the traditional XSSFTestDataSamples.writeOutAndReadBack.
This seems to me like an elegant way of dumping created/modified files for manual review by
opening in Excel or other ooxml tool...if you want this behavior, set the system property,
if not, don't.
>  As part of applying patch 55294, should I generalize this behavior and modify XSSFTestDataSamples.writeOutAndReadBack
to do this?
>
>    Thank you.
>
>             Best,
>
>                      Tim
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>For additional commands, e-mail: dev-help@poi.apache.org
>
>
>
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message