Return-Path: X-Original-To: apmail-poi-dev-archive@www.apache.org Delivered-To: apmail-poi-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2F55CEC1 for ; Thu, 13 Jun 2013 19:45:38 +0000 (UTC) Received: (qmail 17774 invoked by uid 500); 13 Jun 2013 19:45:38 -0000 Delivered-To: apmail-poi-dev-archive@poi.apache.org Received: (qmail 17744 invoked by uid 500); 13 Jun 2013 19:45:38 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 17736 invoked by uid 99); 13 Jun 2013 19:45:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2013 19:45:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jun 2013 19:45:36 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 3ADE419380; Thu, 13 Jun 2013 19:45:15 +0000 (UTC) From: bugzilla@apache.org To: dev@poi.apache.org Subject: [Bug 54686] [PATCH] Some Excel formats are formatted incorrectly by DataFormatter Date: Thu, 13 Jun 2013 19:45:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: XSSF X-Bugzilla-Version: 3.8 X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: tallison@mitre.org X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@poi.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=54686 --- Comment #2 from Tim Allison --- Created attachment 30430 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30430&action=edit 3/4's of a patch, might be good enough Thanks to Ryan Krueger and https://issues.apache.org/jira/browse/TIKA-1132 for the custom formatting test case on fractions. I added some test cases, and offer a 3/4's patch. This patch passes 3148 tests and fails on 38. Without the patch, there are 3062 failurs and 124 successes. I refactored the fraction calculator to avoid the n^2 calculations that could lead to 100,000,000 calculations if the format was ##/####. By "refactored," I mean copied and pasted from org.apache.math.fraction. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org