poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54849] Controlled content/Form (Std/StdBlock) content is not processed
Date Thu, 13 Jun 2013 11:34:12 GMT

Nick Burch <apache@gagravarr.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |NEEDINFO

--- Comment #14 from Nick Burch <apache@gagravarr.org> ---
I've finally had a chance to review this, and on the whole it looks great,

A couple of minor points though:
 * We don't normally use @author tags in the code. The code is maintained,
supported and extended by the whole community, so it's best not to give the
impression that only one person "owns" a bit of code
 * It's generally best to have whitespace fixing up in a different patch/commit
(where possible). Otherwise, it's harder to review the patch for the code
changes, as they end up lost amidst the noise...

I'm minded to try to fix the whitespace stuff, commit that, then ask you to svn
up and then produce an updated patch with just the logic changes in it. Would
that work ok for you?

You are receiving this mail because:
You are the assignee for the bug.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

View raw message