poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54686] [PATCH] Some Excel formats are formatted incorrectly by DataFormatter
Date Thu, 13 Jun 2013 19:45:14 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54686

--- Comment #2 from Tim Allison <tallison@mitre.org> ---
Created attachment 30430
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30430&action=edit
3/4's of a patch, might be good enough

Thanks to Ryan Krueger and https://issues.apache.org/jira/browse/TIKA-1132 for
the custom formatting test case on fractions.  I added some test cases, and
offer a 3/4's patch.  This patch passes 3148 tests and fails on 38.  Without
the patch, there are 3062 failurs and 124 successes.

I refactored the fraction calculator to avoid the n^2 calculations that could
lead to 100,000,000 calculations if the format was ##/####.  By "refactored," I
mean copied and pasted from org.apache.math.fraction.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message