Return-Path: X-Original-To: apmail-poi-dev-archive@www.apache.org Delivered-To: apmail-poi-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9A1B9D35 for ; Sat, 25 May 2013 15:23:47 +0000 (UTC) Received: (qmail 68656 invoked by uid 500); 25 May 2013 15:23:47 -0000 Delivered-To: apmail-poi-dev-archive@poi.apache.org Received: (qmail 68439 invoked by uid 500); 25 May 2013 15:23:46 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 68385 invoked by uid 99); 25 May 2013 15:23:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2013 15:23:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2013 15:23:42 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 882169594; Sat, 25 May 2013 15:23:21 +0000 (UTC) From: bugzilla@apache.org To: dev@poi.apache.org Subject: [Bug 54838] StringBuffer could be replaced by StringBuilder for performance Date: Sat, 25 May 2013 15:23:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: POI Overall X-Bugzilla-Version: 3.9 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: dominik.stadler@gmx.at X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@poi.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=54838 --- Comment #4 from Dominik Stadler --- Created attachment 30324 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30324&action=edit List of places where StringBuffer or Vector are used currently I scanned the current source code for StringBuffer, Vector and HashTable. HashTable seems to be not used anywhere currently. For StringBuffer and Vector I found 551 occurrences all over the place. I would not blindly start replacing all those, risking bugs or race-conditions being introduced underway, without some idea where in the code performance is important and should be improved. Is there a set of unit tests or enhanced tests which run a set of performance-sensitive operations which we can use to profile and analyze where performance improvements are best targeted at? Or are there certain things where you would like to gain performance which could benefit from using the non-thread-safe variants? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org