Return-Path: 
 <dev-return-23287-apmail-poi-dev-archive=poi.apache.org@poi.apache.org>
X-Original-To: apmail-poi-dev-archive@www.apache.org
Delivered-To: apmail-poi-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 747FE98CD
	for <apmail-poi-dev-archive@www.apache.org>;
 Thu, 12 Apr 2012 08:57:43 +0000 (UTC)
Received: (qmail 9830 invoked by uid 500); 12 Apr 2012 08:57:43 -0000
Delivered-To: apmail-poi-dev-archive@poi.apache.org
Received: (qmail 9659 invoked by uid 500); 12 Apr 2012 08:57:41 -0000
Mailing-List: contact dev-help@poi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@poi.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@poi.apache.org>
List-Post: <mailto:dev@poi.apache.org>
List-Id: <dev.poi.apache.org>
Reply-To: "POI Developers List" <dev@poi.apache.org>
Delivered-To: mailing list dev@poi.apache.org
Received: (qmail 9623 invoked by uid 99); 12 Apr 2012 08:57:39 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2012 08:57:39 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2012 08:57:38 +0000
Received: by eir.zones.apache.org (Postfix, from userid 80)
	id 5E7583AE5; Thu, 12 Apr 2012 08:57:13 +0000 (UTC)
From: bugzilla@apache.org
To: dev@poi.apache.org
Subject: DO NOT REPLY [Bug 53058] [PATCH] Utility for representing drawings
 contained in a binary Excel file as a XML tree
Date: Thu, 12 Apr 2012 08:57:02 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: POI
X-Bugzilla-Component: HSSF
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: yegor@dinom.ru
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: dev@poi.apache.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-53058-47293-g4nCc2BAkH@https.issues.apache.org/bugzilla/>
In-Reply-To: <bug-53058-47293@https.issues.apache.org/bugzilla/>
References: <bug-53058-47293@https.issues.apache.org/bugzilla/>
X-Bugzilla-URL: https://issues.apache.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-Virus-Checked: Checked by ClamAV on apache.org

https://issues.apache.org/bugzilla/show_bug.cgi?id=53058

--- Comment #4 from Yegor Kozlov <yegor@dinom.ru> 2012-04-12 08:57:02 UTC ---
Hi Evgeniy,

A very good start! I see that for now only a few records override toXML():
EscherSplitMenuColorsRecord, EscherBSERecord and EscherDggRecord.
Do you plan to implement toXML for the rest of DDF ? I think the answer is
'yes', just want to confirm it. 

For EscherOptRecord it would be great to show properties as child nodes,
something like this:  

<EscherOptRecord>
  <Property id="127" value="32440321" name="protection.lockagainstgrouping"/>
  <Property id="128" value="809474328" name="text.textid"/>
  <Property id="191" value="262148"  name="text.sizetexttofitshape"/>
  <Property id="447" value="1114113"  name="fill.nofillhittest"/>
  <Property id="511" value="1638417" name="linestyle.nolinedrawdash"/>
  <Property id="831" value="524288"  name="shape.backgroundshape"/>
  <Property id="959" value="131072" name="groupshape.print"/>
</EscherOptRecord>

Some records show recordId as decimals, others as hex. It should be unified, I
think hex everywhere would be OK. 

Records thar are not supported (UnknownEscherRecord) should print their data in
hex form:
<UnknownEscherRecord>
  50 4B 03 04 14 00 06 00 08 00 00 00 21 00 98 28 26
</UnknownEscherRecord>

Other than that, very cool! 

Looking forward to working with you on GSoC!

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org