poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 53058] [PATCH] Utility for representing drawings contained in a binary Excel file as a XML tree
Date Thu, 12 Apr 2012 08:57:02 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53058

--- Comment #4 from Yegor Kozlov <yegor@dinom.ru> 2012-04-12 08:57:02 UTC ---
Hi Evgeniy,

A very good start! I see that for now only a few records override toXML():
EscherSplitMenuColorsRecord, EscherBSERecord and EscherDggRecord.
Do you plan to implement toXML for the rest of DDF ? I think the answer is
'yes', just want to confirm it. 

For EscherOptRecord it would be great to show properties as child nodes,
something like this:  

<EscherOptRecord>
  <Property id="127" value="32440321" name="protection.lockagainstgrouping"/>
  <Property id="128" value="809474328" name="text.textid"/>
  <Property id="191" value="262148"  name="text.sizetexttofitshape"/>
  <Property id="447" value="1114113"  name="fill.nofillhittest"/>
  <Property id="511" value="1638417" name="linestyle.nolinedrawdash"/>
  <Property id="831" value="524288"  name="shape.backgroundshape"/>
  <Property id="959" value="131072" name="groupshape.print"/>
</EscherOptRecord>

Some records show recordId as decimals, others as hex. It should be unified, I
think hex everywhere would be OK. 

Records thar are not supported (UnknownEscherRecord) should print their data in
hex form:
<UnknownEscherRecord>
  50 4B 03 04 14 00 06 00 08 00 00 00 21 00 98 28 26
</UnknownEscherRecord>

Other than that, very cool! 

Looking forward to working with you on GSoC!

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message