poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52575] [PATCH] Ignore missing workbook references
Date Fri, 03 Feb 2012 08:46:48 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52575

--- Comment #1 from Yegor Kozlov <yegor@dinom.ru> 2012-02-03 08:46:48 UTC ---
Thanks for the patch. There two things to do before check it in svn:

1. It lacks a unit test(s). Can you write sample code that demonstrates that
the code throws  WorkbookNotFoundException if IGNORE_MISSING_WORKBOOKS=false
and uses cached formula values otherwise. If the test requires input workbooks
then attached them along with the test.

2. What about loading IGNORE_MISSING_WORKBOOKS from a poi.properties file?
First lookup poi.properties in the classpath and then load default config
bundled in the jar. 
My concern is that in many environments users cannot change JVM system
properties, for example, think of a web application that cannot change JVM
settings of the server (Tomcat or whatever). With poi.properties, you can
simply put in the classpath (WEB-INF/classes) and POI will initialize from it 
-  pretty much like log4j searches its config file. 

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message