poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51683] [HSSF] Improve support for Shapes and Shape Groups
Date Sun, 11 Sep 2011 11:04:39 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51683

--- Comment #1 from Yegor Kozlov <yegor@dinom.ru> 2011-09-11 11:04:39 UTC ---
Thanks for the patch. The code looks good, but I'm reluctant to apply it
without a unit test. 

Any chance you could create a test(s) that would create a worksheet with a
drawing group, write, read back and assert the following:

 - shapes from top level group are decoded
 - shapes from nested groups are decoded

I see that you commented clearEscherRecords(). Can you explain why or add a
test that justifies this change:

+        // Now, clear any trace of what records make up
+        //  the patriarch
+        // Otherwise, everything will go horribly wrong
+        //  when we try to write out again....
+//        clearEscherRecords();
+        drawingManager.getDgg().setFileIdClusters(new
EscherDggRecord.FileIdCluster[0]);


Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message