poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51196] [PATCH] Patch to simplify XSSFChart creation
Date Fri, 20 May 2011 08:23:30 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51196

--- Comment #9 from Yegor Kozlov <yegor@dinom.ru> 2011-05-20 08:23:30 UTC ---
Applied in r1125275 with some tweaks.

I see you added two methods to the Drawing interface, but forgot to implement
them in HSSFPatriarch which implements Drawing. No problems - I added
createAnchor and createChart to HSSFPatriarch, createChart throws
NotImplemented for now. For the future, please always run the full Ant test
cycle before creating a patch, i.e. "ant clean test".  

The ScatterChart example throws NPE.  I think the line 69 should call
setYValues, not setXValues:

firstSerie.setYValues(sheet, new CellRangeAddress(1, 1, NUM_OF_COLUMNS + 1,
NUM_OF_COLUMNS + 1));

Please confirm.

The generated output is readable, but differs from the atatched sample file. I
see data rows and an empty graphic frame. Is it still in progress? 

formatAsString

I think a good test would be to create a test file with a chart in Excel and
try to replicate that programmatically in POI. This way we can compare XML
generated by POI with XML generated by Excel and ensure that all is good. What
do you think? 

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message