poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51160] [PATCH] Provide ability to produce very large xlsx files using the regular high level API with the default heap space of 64MB
Date Mon, 09 May 2011 12:39:02 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51160

--- Comment #1 from Yegor Kozlov <yegor@dinom.ru> 2011-05-09 12:39:02 UTC ---
Thanks for the great patch! I'm reviewing it and will give my feedback soon. 

When I wrote BugGridDemo, I had in a generic streaming api in mind, but your
implementation goes far beyond that. Very cool, I should say. 

Some comments on a quick review:

 1. Please remove 'Property of Four Js*' and other copyright statements. By
submitting a patch to Apache POI you agree to the Apache Licence Terms.
 2. the SXSSF classes should live in a separate package under xssf. I propose
to re-package them to org.apache.poi.xssf.streaming.*
 3. I'm in two minds if subclasscing from XSSF was a good idea, most of XSSF
classes are final by design and not meant for extention. Also, many operations
in the streaming mode are not allowed and should throw IllegalStateException.
It would be easier control if SXSSF classes were composites. 
Never mind for now, I will say my final word after review.

 4. The PoiTest application should be renamed to something more descriptive,
e.g. SSPerformanceTest

Please upload a patch against trunk. Your patch applies OK to 3.6, but I had
problems applying it to trunk and had to resolve the rejections.

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message