poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49050] Inefficient concatenation of ContinueRecord contents in AbstractEscherHolderRecord
Date Tue, 06 Apr 2010 03:52:16 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49050

--- Comment #1 from Trejkaz <trejkaz@trypticon.org> 2010-04-06 03:52:15 UTC ---
Created an attachment (id=25231)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25231)
Proposed patch

Proposed patch fixes the issue for that specific record type.

I took a look at some other record types (e.g. DrawingRecord.)  A lot of them
assume a single ContinueRecord and indeed I haven't seen a case of them having
more than one.  But in the event that one day they do, this solution would work
there as well.

Another thing I noticed is that other record types explicitly keep the
ContinueRecord data separate and serialise it separately, whereas with
EscherDrawingRecord this was not the case.  This may not be a problem though, I
just thought it was worth noting.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message