Return-Path: Delivered-To: apmail-poi-dev-archive@www.apache.org Received: (qmail 30137 invoked from network); 22 Dec 2009 08:05:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Dec 2009 08:05:18 -0000 Received: (qmail 81072 invoked by uid 500); 22 Dec 2009 08:04:29 -0000 Delivered-To: apmail-poi-dev-archive@poi.apache.org Received: (qmail 80601 invoked by uid 500); 22 Dec 2009 08:04:24 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 80281 invoked by uid 99); 22 Dec 2009 08:04:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2009 08:04:18 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2009 08:04:11 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 25315234C04C; Tue, 22 Dec 2009 00:03:51 -0800 (PST) From: bugzilla@apache.org To: dev@poi.apache.org Subject: DO NOT REPLY [Bug 48425] DateUtil.isCellDateFormatted() method is slow X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: POI Overall X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: yegor@dinom.ru X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@poi.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20091222080351.25315234C04C@brutus.apache.org> Date: Tue, 22 Dec 2009 00:03:51 -0800 (PST) https://issues.apache.org/bugzilla/show_bug.cgi?id=48425 Yegor Kozlov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Yegor Kozlov 2009-12-22 00:03:45 UTC --- A good catch, thanks. As you suggested, I replaced the first five regexes with a loop collecting characters into a buffer. The remaining three regexes are pre-compiled at class initialization time. In my benchmark I measured the number of calls to DateUtil.isCellDateFormatted() made in ten seconds. The reworked code is significantly faster: the throughput is at least five times greater. I committed the fix in r893105. Yegor -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org