poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 48425] DateUtil.isCellDateFormatted() method is slow
Date Tue, 22 Dec 2009 08:03:51 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=48425

Yegor Kozlov <yegor@dinom.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Yegor Kozlov <yegor@dinom.ru> 2009-12-22 00:03:45 UTC ---
A good catch, thanks. 

As you suggested, I replaced the first five regexes with a loop collecting
characters into a buffer. The remaining three regexes are pre-compiled at class
initialization time. 

In my benchmark I measured the number of calls to
DateUtil.isCellDateFormatted() made in ten seconds. The reworked code is
significantly faster: the throughput is at least five times greater. 

I committed the fix in r893105. 

Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message