poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47652] [PATCH] Initial support for encrypted workbooks
Date Fri, 07 Aug 2009 06:30:25 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47652


Josh Micich <josh@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


--- Comment #6 from Josh Micich <josh@gildedtree.com> 2009-08-06 23:30:22 PDT ---
Fixed in svn r801890

I had independently worked a solution a few months back but hadn't got round to
submitting it.  The changes I have submitted are mostly based on my own work,
but I  also added some things from your patch that I had missed out:
  - a high level test case
  - better handling of first three ushort fields FILEPASS (BTW - where did you
get that info?)

Some stuff that I had already done:
  - low level unit tests for password/key verification, and key block changes
(the tested code is very hard to understand/maintain solely in the context of
high level use cases). 
  - handle the user password with a ThreadLocal instead of a plain static
field.  This should enable separate threads to decrypt independently.
  - management of which BIFF records get encrypted is managed down in Biff8RC4
(instead of RecordInputStream).  This will allow encrypting code (not done yet)
to use the same logic easily.

Please take a look a the combined changes which are already in svn trunk, and
let me know if it still meets your needs.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message