poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47520] [PATCH] Implementation of an XLSX to XML Exporter using Custom XML Mapping
Date Mon, 13 Jul 2009 18:11:42 GMT

--- Comment #2 from Yegor Kozlov <yegor@dinom.ru>  2009-07-13 11:11:39 PST ---

Thanks for the patch. I gave a quick look and have the following comments: 

 - Did you make any changes to XSSFFactory?  I guess you did, otherwise
workbook.getRelations()  would never return instances of MapInfo. Please
re-attach the full diff. 
 - Please normalize your code to use org.apache.poi.ss.util.CellReference
instead of XSSFCellReference. The latter class is redundant. 
 - Can you provide an example based on the posted code so that we include it in
the XSSF examples? It would be very handy.


Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

View raw message