Return-Path: Delivered-To: apmail-poi-dev-archive@www.apache.org Received: (qmail 44258 invoked from network); 12 Mar 2009 05:20:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Mar 2009 05:20:24 -0000 Received: (qmail 1825 invoked by uid 500); 12 Mar 2009 05:20:23 -0000 Delivered-To: apmail-poi-dev-archive@poi.apache.org Received: (qmail 1799 invoked by uid 500); 12 Mar 2009 05:20:23 -0000 Mailing-List: contact dev-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "POI Developers List" Delivered-To: mailing list dev@poi.apache.org Received: (qmail 1788 invoked by uid 500); 12 Mar 2009 05:20:23 -0000 Delivered-To: apmail-jakarta-poi-dev@jakarta.apache.org Received: (qmail 1785 invoked by uid 99); 12 Mar 2009 05:20:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2009 22:20:23 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2009 05:20:21 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 947D6234C041; Wed, 11 Mar 2009 22:20:01 -0700 (PDT) From: bugzilla@apache.org To: poi-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 41933] PicturesTable#getAlllPictures() sometimes loses images X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: newchanged X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: POI X-Bugzilla-Component: HWPF X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: trejkaz@trypticon.org X-Bugzilla-Status: NEEDINFO X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: poi-dev@jakarta.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: References: Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <20090312052001.947D6234C041@brutus.apache.org> Date: Wed, 11 Mar 2009 22:20:01 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=41933 --- Comment #8 from Trejkaz 2009-03-11 22:20:00 PST --- Looking at the current trunk version (and the slightly older version we're running) it seems that half of my workaround (rewritten) ended up becoming the current version of getAllPictures(). The only inconsistency is that the rewrite in the POI version results in it returning the same image multiple times (as it's no longer building the map to keep track of this.) I'm not sure whether I should (a) modify POI so that it removes the duplicates and submit that up, or (b) add some method to Picture so that I can de-duplicate myself from the outside, and then submit that smaller modification up. Obviously I'm leaning toward (a) but since it seems like the duplicate removal was intentionally removed from the code, perhaps (b) is the better option? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org